Skip to content

[SPARK-56153][SQL][TESTS][FOLLOWUP] Remove unnecessary asInstanceOf[classic.Dataset] casts in QueryTest#55339

Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:remove-unnecessary-dataset-cast
Closed

[SPARK-56153][SQL][TESTS][FOLLOWUP] Remove unnecessary asInstanceOf[classic.Dataset] casts in QueryTest#55339
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:remove-unnecessary-dataset-cast

Conversation

@zhengruifeng
Copy link
Copy Markdown
Contributor

@zhengruifeng zhengruifeng commented Apr 14, 2026

What changes were proposed in this pull request?

Remove three unnecessary asInstanceOf[classic.Dataset[_]] casts in QueryTest.scala (assertCached and assertEmptyMissingInput methods). The api-level Dataset already declares queryExecution (with @ClassicOnly annotation, which is purely documentation), so the casts are redundant.

Why are the changes needed?

The casts are unnecessary because:

  1. The api-level Dataset already declares def queryExecution: QueryExecution — calling it directly works without casting to classic.Dataset.
  2. The same file already calls ds.queryExecution directly without a cast on line 126 (getResult method), confirming this is safe.
  3. The @ClassicOnly annotation is a runtime documentation annotation with no compile-time effect.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests (unable to compile locally due to missing lz4-java:1.11.0 dependency in environment).

Was this patch authored or co-authored using generative AI tooling?

Co-authored-by: Claude code (Opus 4.6)

@zhengruifeng zhengruifeng changed the title [SPARK-XXXXX][SQL] Remove unnecessary asInstanceOf[classic.Dataset] casts in QueryTest [SPARK-56153][SQL][TESTS][FOLLOWUP] Remove unnecessary asInstanceOf[classic.Dataset] casts in QueryTest Apr 14, 2026
Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works

@zhengruifeng zhengruifeng marked this pull request as ready for review April 15, 2026 00:34
@zhengruifeng
Copy link
Copy Markdown
Contributor Author

merged to master

@zhengruifeng zhengruifeng deleted the remove-unnecessary-dataset-cast branch April 15, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants