Skip to content

[SPARK-56573][SQL] Widen the default tablesample seed to reduce collisions #56608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilmerdooley wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −6
Open

[SPARK-56573][SQL] Widen the default tablesample seed to reduce collisions #56608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics}
import org.apache.spark.sql.internal.{SQLConf, StaticSQLConf}
import org.apache.spark.sql.types.{LongType, StructType}
import org.apache.spark.sql.vectorized.ColumnarBatch
import org.apache.spark.util.ThreadUtils
import org.apache.spark.util.{ThreadUtils, Utils}
import org.apache.spark.util.random.{BernoulliCellSampler, PoissonSampler}

/** Physical plan for Project. */
Expand Down Expand Up @@ -482,7 +482,7 @@ case class SampleExec(
seed: Option[Long],
child: SparkPlan) extends UnaryExecNode with CodegenSupport {

val resolvedSeed: Long = seed.getOrElse((math.random() * 1000).toLong)
val resolvedSeed: Long = seed.getOrElse(Utils.random.nextLong())

override def output: Seq[Attribute] = child.output

Expand Down
5 changes: 1 addition & 4 deletions ...src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,10 +897,7 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper {
sample.lowerBound,
sample.upperBound,
sample.withReplacement,
// TODO(SPARK-56573): The * 1000 limits the seed to only 1000 distinct values.
// Kept here for consistency with SampleExec.resolvedSeed; will be fixed
// across all call sites in SPARK-56573.
sample.seed.getOrElse((math.random() * 1000).toLong),
sample.seed.getOrElse(Utils.random.nextLong()),
sampleMethod = sample.sampleMethod)
val pushed = PushDownUtils.pushTableSample(sHolder.builder, tableSample)
if (pushed) {
Expand Down