[SPARK-58573][INFRA][BUILD] Replace defunct Jenkins test grouping with modern GitHub Actions grouping - #57770
Open
nchammas wants to merge 3 commits into
Open
[SPARK-58573][INFRA][BUILD] Replace defunct Jenkins test grouping with modern GitHub Actions grouping#57770nchammas wants to merge 3 commits into
nchammas wants to merge 3 commits into
Conversation
nchammas
marked this pull request as ready for review
August 4, 2026 20:18
Contributor
Author
|
cc @gaogaotiantian since you authored #54524. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the old
CURRENT_BLOCKandERROR_CODEStesting infrastructure and replace it with an updatedtitled_blockcontext manager that also groups log output on GitHub Actions.Make sure that title blocks cannot be nested, and that all large blocks of output have a suitable title block at the top level
main()function.Fold
group_in_github_actionsinto the newtitled_block.Remove
build_spark_documentation, which is not used by anything.Why are the changes needed?
Amusingly, I added the old testing infrastructure 12 years ago in #2606. It was built for Jenkins, which we do not use anymore. The block and error codes are not used by any part of our current test infrastructure on GitHub Actions.
The new
titled_blockcontext manager takes care of printing block titles as before, and also subsumes the log grouping behavior fromgroup_in_github_actions(introduced in #54524) since it is useful for more than just sbt.We have a separate job for building the docs, so I assume we don't want to revive the currently-dead
build_spark_documentation.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI for this PR. Some illustrative screenshots of the new log groups:
The purple debug lines are from my fork and are not related to this PR.
Was this patch authored or co-authored using generative AI tooling?
I wrote this with assistance from GitHub Copilot.