fix(chart): added Big Number chart support for MAX metric with VARCHAR column by omkarhall · Pull Request #41182 · apache/superset

omkarhall · 2026-06-18T03:30:19Z

SUMMARY

The issue I am addressing is that Big Number charts previously displayed "No data" when the metric result was a non-empty, non-date string value. My fix for this is the below:
In utils.ts parseMetricValue returns null for non-date strings. Now, in transformProps.ts after parseMetricValue returns null, if the original raw value was a non-empty string, it falls back to that string. BigNumberViz.tsx already handles string bigNumber by displaying it directly so "No data" will no longer appear.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TESTING INSTRUCTIONS

Start Superset locally.
Create or use a dataset with a non-null VARCHAR column.
Create a Big Number chart using that dataset.
Set the metric to MAX(varchar_column).
Click Create Chart.

ADDITIONAL INFORMATION

Has associated issue: Big Number shows "No data" when query result is non-empty if column is not numeric or date #41030
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…R column

bito-code-review · 2026-06-18T03:30:29Z

Code Review Agent Run #9f10b0

Actionable Suggestions - 0

Additional Suggestions - 1

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/utils.ts - 1
- Behavior change for invalid dates · Line 40-40
  
  The change from `return null` to `return metricValue` alters the behavior for invalid date strings. Previously, strings like `'abc'` would return `null` (displayed as 'No data'); now they pass through unchanged and may be displayed as-is. Additionally, `BigNumberPeriodOverPeriod/transformProps.ts` has a duplicate `parseMetricValue` that returns `0` for the same case — verify this is the intended divergence.

Review Details

Files reviewed - 1 · Commit Range: de470af..de470af
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/utils.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-06-18T03:36:18Z

The flagged issue is correct. Returning raw strings from parseMetricValue breaks downstream numeric calculations, such as trendline aggregation and percentage change, which expect numeric values and will result in NaN when encountering strings. To resolve this, parseMetricValue should continue returning null for non-date strings in shared paths, and string preservation should be handled explicitly only where needed (e.g., in the Big Number Total path).

Here is the corrected implementation for superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/utils.ts:

    if (dateObject.isValid()) {
      return dateObject.valueOf();
    }
    return null;
  }
  return metricValue;
};

There are no other comments in the provided review data to address. Would you like me to check for any other potential issues in this file?

superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/utils.ts

if (dateObject.isValid()) {
      return dateObject.valueOf();
    }
    return null;
  }
  return metricValue;
};

bito-code-review · 2026-06-18T07:33:54Z

Code Review Agent Run #f0e81d

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: de470af..971a7c3
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/utils.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codecov · 2026-06-18T15:12:59Z

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.31%. Comparing base (7e98410) to head (971a7c3).
⚠️ Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
...rts/src/BigNumber/BigNumberTotal/transformProps.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #41182      +/-   ##
==========================================
- Coverage   64.31%   64.31%   -0.01%     
==========================================
  Files        2651     2651              
  Lines      144784   144788       +4     
  Branches    33409    33413       +4     
==========================================
- Hits        93125    93122       -3     
- Misses      49991    49998       +7     
  Partials     1668     1668

Flag	Coverage Δ
javascript	`68.45% <80.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

netlify · 2026-06-18T16:05:33Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`1cb8746`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a3416dcc2673400080e5500
😎 Deploy Preview	https://deploy-preview-41182--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

…s and added test

bito-code-review · 2026-06-18T19:05:13Z

Code Review Agent Run #db677e

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 971a7c3..0df282d
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.test.ts
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

fix(chart): added Big Number chart support for MAX metric with VARCHA…

de470af

…R column

pull-request-size Bot added the size/XS label Jun 18, 2026

dosubot Bot added the viz:charts:bignumber Related to BigNumber charts label Jun 18, 2026

github-actions Bot added the plugins label Jun 18, 2026

codeant-ai-for-open-source Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/utils.ts Outdated

fix(chart): apply string preservation only in Big Number Total path

971a7c3

fix(chart): added test to simulate non-date VARCHAR

1cb8746

pull-request-size Bot added size/M and removed size/XS labels Jun 18, 2026

codeant-ai-for-open-source Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts Outdated

fix(chart): ensured that numeric strings do not get formatted as date…

0df282d

…s and added test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(chart): added Big Number chart support for MAX metric with VARCHAR column#41182

fix(chart): added Big Number chart support for MAX metric with VARCHAR column#41182
omkarhall wants to merge 4 commits into
apache:masterfrom
omkarhall:feature/big-number-support-non-numeric

omkarhall commented Jun 18, 2026 •

edited

Loading

Uh oh!

bito-code-review Bot commented Jun 18, 2026 •

edited

Loading

Code Review Agent Run #9f10b0

Uh oh!

Uh oh!

bito-code-review Bot commented Jun 18, 2026

Uh oh!

bito-code-review Bot commented Jun 18, 2026 •

edited

Loading

Code Review Agent Run #f0e81d

Uh oh!

codecov Bot commented Jun 18, 2026

Uh oh!

netlify Bot commented Jun 18, 2026

Uh oh!

Uh oh!

bito-code-review Bot commented Jun 18, 2026 •

edited

Loading

Code Review Agent Run #db677e

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

omkarhall commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #9f10b0

Uh oh!

Uh oh!

bito-code-review Bot commented Jun 18, 2026

Uh oh!

bito-code-review Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #f0e81d

Uh oh!

codecov Bot commented Jun 18, 2026

Codecov Report

Uh oh!

netlify Bot commented Jun 18, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

Uh oh!

bito-code-review Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #db677e

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

omkarhall commented Jun 18, 2026 •

edited

Loading

bito-code-review Bot commented Jun 18, 2026 •

edited

Loading

bito-code-review Bot commented Jun 18, 2026 •

edited

Loading

bito-code-review Bot commented Jun 18, 2026 •

edited

Loading