chore(deps): finish pip→uv swap in Makefile and CI#41197
Open
msyavuz wants to merge 2 commits into
Open
Conversation
Use uv pip install at the remaining raw-pip call sites: the Makefile local-dev targets (superset, update-py, pre-commit) and the CI steps that build the editable package (bashlib.sh testdata/playwright_testdata, superset-app-cli, superset-python-presto-hive). uv already drives dependency compilation (uv pip compile via scripts/uv-pip-compile.sh) and every other install site (setup-backend, Dockerfile, docker/pip-install.sh). These were the last stragglers. The pinned requirements/*.txt and pyproject.toml are unchanged; this is the drop-in uv pip compatibility interface only. The Makefile bootstraps uv into the active venv first; CI sites already have uv installed system-wide via setup-backend. Intentional command -v uv fallbacks in docker-bootstrap.sh (older images) are left in place.
msyavuz
requested review from
betodealmeida,
craig-rueda,
dpgaspar,
eschutho,
geido,
hainenber,
kgabryje,
mistercrunch,
nytai,
rusackas,
sadpandajoe and
villebro
as code owners
Contributor
Code Review Agent Run #71be03Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
Bot
added
github_actions
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41197 +/- ##
=======================================
Coverage 64.33% 64.33%
=======================================
Files 2651 2651
Lines 144766 144766
Branches 33401 33401
=======================================
Hits 93131 93131
Misses 49965 49965
Partials 1670 1670
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
uvalready drives Python dependency compilation (uv pip compileviascripts/uv-pip-compile.sh) and every install site in CI and Docker (setup-backend,Dockerfile,docker/pip-install.sh). A few raw-pipcall sites were left behind; this swaps them to theuv pipcompatibility interface so the toolchain is consistent.Changed call sites:
superset,update-py,pre-committargets (bootstrapsuvinto the active venv, thenuv pip install)bashlib.sh(testdata/playwright_testdata),superset-app-cli,superset-python-presto-hiveNo change to
requirements/*.txtorpyproject.toml— this is the drop-inuv pipinterface only, not a move touv.lock/uv sync. CI sites already haveuvinstalled system-wide viasetup-backend, so they use--system. The intentionalcommand -v uvfallbacks indocker/docker-bootstrap.sh(for older images) are left in place.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — build/CI tooling only, no UI.
TESTING INSTRUCTIONS
make -n superset/make -n update-py/make -n pre-commitshowuv pip install.uv pip install --system -e .and pass.bash -n .github/workflows/bashlib.shis clean.ADDITIONAL INFORMATION