Skip to content

fix: remove erroneous box shadow when bulk selecting#41198

Open
vhogberg wants to merge 1 commit into
apache:masterfrom
vhogberg:fix/bulk-selection-box-shadow
Open

fix: remove erroneous box shadow when bulk selecting#41198
vhogberg wants to merge 1 commit into
apache:masterfrom
vhogberg:fix/bulk-selection-box-shadow

Conversation

@vhogberg

@vhogberg vhogberg commented Jun 18, 2026

Copy link
Copy Markdown

SUMMARY

Remove the erroneous box shadow when bulk selecting that creates a vertical 1px line.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

-->

image

TESTING INSTRUCTIONS

Use bulk selection in the dashboards/charts/datasets list. Select one or more items, observe that the line is gone.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review

bito-code-review Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #60006e

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 149048b..149048b
    • superset-frontend/src/components/ListView/ListView.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot Bot added the listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. label Jun 18, 2026
@vhogberg vhogberg force-pushed the fix/bulk-selection-box-shadow branch from 149048b to cb67584 Compare June 18, 2026 13:14
@bito-code-review

bito-code-review Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #33a10b

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: cb67584..cb67584
    • superset-frontend/src/components/ListView/ListView.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vhogberg