fix(dashboard): copy workflow opens preview page instead of workspace#4280
Open
seongjinyoon wants to merge 2 commits intoapache:mainfrom
Open
fix(dashboard): copy workflow opens preview page instead of workspace#4280seongjinyoon wants to merge 2 commits intoapache:mainfrom
seongjinyoon wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
@kunwp1 Please review it. |
kunwp1
requested changes
Mar 12, 2026
Contributor
kunwp1
left a comment
kunwp1
left a comment
There was a problem hiding this comment.
Your change fixes the issue but I suggest you address the comment below.
| workflow: w, | ||
| })); | ||
| const newEntries = await firstValueFrom( | ||
| this.searchService.extendSearchResultsWithHubActivityInfo(searchResultItems, this.isLogin, ["access"]) |
Contributor
There was a problem hiding this comment.
I think your fix is an overkill. Your fix relies on Hub service for a new duplicated workflow which is adding an extra network call. For a workflow we just duplicated, frontend already knows a current user is the owner of the workflow. So I suggest you fix the place that decides the link (whether to open a workspace or a preview page).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Problem:
When copying a workflow from the "Workflows" tab under "Your Work", clicking on the newly copied workflow incorrectly redirected to the preview page instead of opening it in the workspace. More on #3829
Root Cause:
After a workflow is copied, a new
DashboardEntryis constructed, manually appending information such as owner's name, and avatar. However, the issue is that the list of user IDs with access was not appended, causing the routing to go to the preview page.Fix:
Instead of the current hardcoded method of constructing
DashboardEntryobjects, the proposed method reuses theextendSearchResultsWithHubActivityInfo()method in SearchService. This ensures the owner info and access info are fetched from the backend consistently and is correctly populated.Changes:
user-workflow.component.ts:extendSearchResultsWithHubActivityInfo()method in SearchService.UserInfoimport.Any related issues, documentation, discussions?
Closes #3829
How was this PR tested?
Manually tested
Was this PR authored or co-authored using generative AI tooling?
Revised with Claude Code.