refactor(auth): use SecureRandom for random hex string generation#4285
Open
carloea2 wants to merge 2 commits intoapache:mainfrom
Open
refactor(auth): use SecureRandom for random hex string generation#4285carloea2 wants to merge 2 commits intoapache:mainfrom
carloea2 wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR updates random hex string generation in the Auth module to use
SecureRandominstead ofRandom.It also changes the hex string construction to use fixed-width integer-to-hex conversion (
%08x), so each generated integer consistently contributes 8 hexadecimal characters. This keeps the generated value length stable and makes the implementation more predictable across environments.Current Implementation:
texera/common/config/src/main/scala/org/apache/texera/config/AuthConfig.scala
Lines 48 to 55 in 3e46cea
Any related issues, documentation, discussions?
Closes #4284
How was this PR tested?
Manually verified that the updated implementation:
Was this PR authored or co-authored using generative AI tooling?
No