chore(license): switch to DISCLAIMER-WIP and add ASF licensing files to JARs and Docker images#4288
Open
bobbai00 wants to merge 6 commits intoapache:mainfrom
Open
chore(license): switch to DISCLAIMER-WIP and add ASF licensing files to JARs and Docker images#4288bobbai00 wants to merge 6 commits intoapache:mainfrom
bobbai00 wants to merge 6 commits intoapache:mainfrom
Conversation
Instead of hard-copying LICENSE/NOTICE/DISCLAIMER-WIP into each service's src/main/resources/META-INF/, use sbt resourceGenerators to copy them from the repo root at build time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
dependencies
Task {} macro requires sbt 1.10+. Use Def.task {}.taskValue instead.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bobbai00
changed the title
Contributor
Author
|
Dear @pjfanning , can you please review this PR? |
Contributor
|
In my understanding, this is a temporary workaround to unblock a release, and we have to eventually finish the original task. So I don't think this PR should close the issue #4131. If we do choose this solution and closes #4131, then we have to open another issue so that we don't forget about this in the future. |
Contributor
Author
Make sense. I updated the PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
DISCLAIMERtoDISCLAIMER-WIPusing the ASF-required template from the incubation policy, listing the incomplete dependency license audit as a known issue.LICENSE,NOTICE, andDISCLAIMER-WIPto every Texera JAR'sMETA-INF/directory via an sbtresourceGeneratorstask that dynamically copies them from the repo root at build time.COPYinstructions in all 8 Dockerfiles to includeLICENSE,NOTICE, andDISCLAIMER-WIPat/texera/in every Docker image.Any related issues, documentation, discussions?
A workaround based on #4131
How was this PR tested?
DISCLAIMER-WIPcontent follows the ASF incubation policy template.resourceGeneratorssetting compiles and is applied to all subprojects.Was this PR authored or co-authored using generative AI tooling?
Co-created with: Claude Code (Claude Opus 4.6)