Skip to content

fix(ui): update computing unit status on /compute tab every second #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gracecluvohio wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −0
Open

fix(ui): update computing unit status on /compute tab every second #4612

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58aa087
fix(ui): update computing unit status on /compute tab every second
gracecluvohio May 1, 2026
488e9a6
refactor: remove console logging for refreshing computing unit status
gracecluvohio May 1, 2026
7191fd9
Merge branch 'main' into grace/fix-computing-unit-status
chenlica May 2, 2026
0fb94a7
Merge branch 'main' into grace/fix-computing-unit-status
Yicong-Huang May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...end/src/app/dashboard/component/user/user-computing-unit/user-computing-unit.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {
getJvmMemorySliderConfig,
} from "../../../../common/util/computing-unit.util";
import { ComputingUnitActionsService } from "../../../../common/service/computing-unit/computing-unit-actions/computing-unit-actions.service";
import { interval } from "rxjs";

@UntilDestroy()
@Component({
Expand Down Expand Up @@ -145,6 +146,12 @@ export class UserComputingUnitComponent implements OnInit {
this.allComputingUnits = units;
this.entries = units.map(u => new DashboardEntry(u));
});

interval(1000)
.pipe(untilDestroyed(this))
.subscribe(() => {
this.computingUnitStatusService.refreshComputingUnitList();
});
Comment on lines +150 to +154
Copy link
Copy Markdown
Contributor

@Yicong-Huang Yicong-Huang May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make it event driven, instead of every second?

Copy link
Copy Markdown
Contributor Author

@gracecluvohio gracecluvohio May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a better user experience to make it every second, so that the status is as fresh as possible.

Copy link
Copy Markdown
Contributor

@Yicong-Huang Yicong-Huang May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can deliver the same user experience. I am talking about implementation. can we make it event driven? for example, when some status changed, push an event to frontend to update the computing unit list.

Copy link
Copy Markdown
Contributor Author

@gracecluvohio gracecluvohio May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, I don't think the existing services we have expose "messages" or events sent from the backend, they just expose functionality for refreshing all of the computing units. I think a timer based refreshing is most consistent with the functions we currently have.

}

terminateComputingUnit(cuid: number): void {
Expand Down
Loading