refactor(amber): rename remaining Akka* identifiers to Pekko*#4949
Open
Yicong-Huang wants to merge 1 commit intoapache:mainfrom
Open
refactor(amber): rename remaining Akka* identifiers to Pekko*#4949Yicong-Huang wants to merge 1 commit intoapache:mainfrom
Yicong-Huang wants to merge 1 commit intoapache:mainfrom
Conversation
The project moved off Akka onto Apache Pekko, but several internal Scala identifiers still carried the `Akka` prefix even though they wrap Pekko APIs — confusing when grepping the codebase for the actor runtime. Pure rename: - `AkkaConfig` → `PekkoConfig` (object + file) - `AkkaActorService` → `PekkoActorService` (class + file) - `AkkaActorRefMappingService` → `PekkoActorRefMappingService` - `AkkaMessageTransferService` → `PekkoMessageTransferService` - `akkaConfig`, `akkaActorService` (methods/params) → pekko-prefixed. No string literals, config keys, or serialization registrations change — `cluster.conf` already uses `pekko.*` keys, kryo registry doesn't reference these classes by name. The intentional `"akka"` comment in `DeployStrategiesSpec.scala` (which contrasts pekko vs akka address strings) stays. Closes apache#4948.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4949 +/- ##
=========================================
Coverage 42.22% 42.22%
Complexity 2181 2181
=========================================
Files 980 980
Lines 36287 36287
Branches 3783 3783
=========================================
+ Hits 15322 15323 +1
Misses 20037 20037
+ Partials 928 927 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Keeping this PR rename-only on purpose so it stays trivially revertable. The 82.6% patch coverage flag is a codecov artifact: project coverage is unchanged (+1 hit, −1 partial) — those four lines were already uncovered on main, the rename just made codecov re-attribute them to this patch. Will add tests for the actor-service / AmberRuntime gap in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The project moved off Akka onto Apache Pekko, but several internal Scala identifiers still carried the
Akkaprefix even though they wrap Pekko APIs. Pure rename acrossamberandcommon/config:AkkaConfig→PekkoConfig(object + file)AkkaActorService→PekkoActorService(class + file)AkkaActorRefMappingService→PekkoActorRefMappingServiceAkkaMessageTransferService→PekkoMessageTransferServiceakkaConfig,akkaActorServicemethod/parameter names → pekko-prefixedNo behavior change. No string literals, config keys, or serialization registrations are touched —
cluster.confalready usespekko.*keys, the kryo registry doesn't reference these classes by name. The intentional"akka"literal inDeployStrategiesSpec.scalathat contrasts pekko vs akka address strings stays.Any related issues, documentation, discussions?
Closes #4948.
How was this PR tested?
sbt WorkflowExecutionService/Test/compileclean,sbt WorkflowExecutionService/scalafmtCheckAllclean.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (Claude Code)