Skip to content

Conversation

@Aggarwal-Raghav
Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav commented Nov 12, 2025

  • Upgrade to commons-lang-3.19.0
  • org.apache.commons.lang.ArrayUtils => org.apache.commons.lang3.ArrayUtils
  • org.apache.commons.lang.RandomStringUtils => org.apache.commons.lang3.RandomStringUtils
  • org.apache.commons.lang.StringEscapeUtils => org.apache.commons.lang3.StringEscapeUtils
  • org.apache.commons.lang.StringUtils => org.apache.commons.lang3.StringUtils
  • org.apache.commons.lang.SystemUtils => org.apache.commons.lang3.SystemUtils
  • org.apache.commons.lang.exception.ExceptionUtils => org.apache.commons.lang3.exception.ExceptionUtils
  • org.apache.commons.lang.mutable.MutableInt => org.apache.commons.lang3.mutable.MutableInt
  • org.apache.commons.lang.NotImplementedException => org.apache.commons.lang3.NotImplementedException

@Aggarwal-Raghav
Copy link
Contributor Author

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav
Copy link
Contributor Author

Looks like UT failures are because of exclusion of common-lang 2.x in hadoop-yarn-server-tests jar. I have removed the exclusions. As the jar is in test scope dependency, we are only shipping commons-lang3.x.

From Hive perspective, commons-lang 2.x is part of hive-exec jar so, it shouldn't cause any runtime issues as well.

https://github.com/apache/hive/blob/c054a47c7c22875c93ca0d29b7ac730cf7deba04/ql/pom.xml#L1060

CC @abstractdog

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 12 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 2m 54s Maven dependency ordering for branch
+1 💚 mvninstall 10m 48s master passed
+1 💚 compile 7m 7s master passed
+1 💚 checkstyle 4m 31s master passed
+1 💚 javadoc 5m 8s master passed
+0 🆗 spotbugs 2m 15s tez-api in master has 610 extant spotbugs warnings.
+0 🆗 spotbugs 0m 53s tez-runtime-internals in master has 114 extant spotbugs warnings.
+0 🆗 spotbugs 1m 15s tez-runtime-library in master has 241 extant spotbugs warnings.
+0 🆗 spotbugs 0m 57s tez-mapreduce in master has 129 extant spotbugs warnings.
+0 🆗 spotbugs 1m 49s tez-dag in master has 785 extant spotbugs warnings.
+0 🆗 spotbugs 0m 53s tez-tests in master has 6 extant spotbugs warnings.
+0 🆗 spotbugs 0m 48s tez-plugins/tez-history-parser in master has 21 extant spotbugs warnings.
+0 🆗 spotbugs 0m 38s tez-tools/tez-javadoc-tools in master has 3 extant spotbugs warnings.
+0 🆗 spotbugs 7m 31s root in master has 2066 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 21s /patch-mvninstall-tez-tests.txt tez-tests in the patch failed.
-1 ❌ mvninstall 0m 10s /patch-mvninstall-tez-tools_tez-javadoc-tools.txt tez-javadoc-tools in the patch failed.
+1 💚 codespell 1m 0s No new issues.
+1 💚 compile 7m 4s the patch passed
+1 💚 javac 7m 4s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 4m 9s the patch passed
+1 💚 javadoc 5m 2s the patch passed
+1 💚 spotbugs 18m 22s the patch passed
_ Other Tests _
+1 💚 unit 2m 28s tez-api in the patch passed.
+1 💚 unit 1m 4s tez-runtime-internals in the patch passed.
+1 💚 unit 6m 0s tez-runtime-library in the patch passed.
+1 💚 unit 1m 34s tez-mapreduce in the patch passed.
+1 💚 unit 5m 16s tez-dag in the patch passed.
+1 💚 unit 35m 40s tez-tests in the patch passed.
+1 💚 unit 2m 29s tez-history-parser in the patch passed.
+1 💚 unit 0m 29s tez-javadoc-tools in the patch passed.
+1 💚 unit 69m 37s root in the patch passed.
+1 💚 asflicense 3m 45s The patch does not generate ASF License warnings.
225m 48s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/2/artifact/out/Dockerfile
GITHUB PR #441
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
uname Linux 01a8e1014b78 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/src/.yetus/personality.sh
git revision master / cafecd5
Default Java Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/2/testReport/
Max. process+thread count 2097 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-tests tez-plugins/tez-history-parser tez-tools/tez-javadoc-tools . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-441/2/console
versions git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor

abstractdog commented Dec 2, 2025

@Aggarwal-Raghav : I can see only 1 problem in tez-javadoc-tools while compiling the java 17+ version

@Aggarwal-Raghav
Copy link
Contributor Author

Aggarwal-Raghav commented Dec 2, 2025

@Aggarwal-Raghav : I can see only 1 problem in tez-javadoc-tools while compiling the java 17+ version

@abstractdog , it is passing in local. Attaching the build logs for this module. Do i need to force push again?
tez-javadoc-buid.txt

@Aggarwal-Raghav
Copy link
Contributor Author

Please suggest, what needs to be done.

@abstractdog abstractdog self-requested a review January 22, 2026 11:15
@abstractdog
Copy link
Contributor

abstractdog commented Jan 22, 2026

Please suggest, what needs to be done.

sorry for the late reply, it has passed for me too locally, can you rebase and push to see it now? and then we'll decide

- Upgrade to commons-lang-3.19.0
- org.apache.commons.lang.ArrayUtils => org.apache.commons.lang3.ArrayUtils
- org.apache.commons.lang.RandomStringUtils => org.apache.commons.lang3.RandomStringUtils
- org.apache.commons.lang.StringEscapeUtils => org.apache.commons.lang3.StringEscapeUtils
- org.apache.commons.lang.StringUtils => org.apache.commons.lang3.StringUtils
- org.apache.commons.lang.SystemUtils => org.apache.commons.lang3.SystemUtils
- org.apache.commons.lang.exception.ExceptionUtils => org.apache.commons.lang3.exception.ExceptionUtils
- org.apache.commons.lang.mutable.MutableInt => org.apache.commons.lang3.mutable.MutableInt
- org.apache.commons.lang.NotImplementedException => org.apache.commons.lang3.NotImplementedException
@Aggarwal-Raghav
Copy link
Contributor Author

No Worries. Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants