Skip to content

Conversation

@Aggarwal-Raghav
Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav commented Nov 12, 2025

  • Exclusion of netty dependency from hadoop-common test-jar dependency

Dependency Tree:
netty-changes-dependency-tree.txt

Screenshot 2026-01-22 at 5 45 29 PM

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 13m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 9m 44s master passed
+1 💚 compile 1m 18s master passed
+1 💚 javadoc 1m 4s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 38s the patch passed
+1 💚 codespell 0m 28s No new issues.
+1 💚 compile 1m 15s the patch passed
+1 💚 javac 1m 15s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 javadoc 0m 43s the patch passed
_ Other Tests _
+1 💚 unit 60m 14s root in the patch passed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
92m 38s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/1/artifact/out/Dockerfile
GITHUB PR #442
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile
uname Linux 6707cee02c51 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-442/src/.yetus/personality.sh
git revision master / 1e3ee2c
Default Java Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/1/testReport/
Max. process+thread count 1442 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/1/console
versions git=2.43.0 maven=3.8.7 codespell=2.0.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog self-requested a review November 12, 2025 14:22
<artifactId>jersey-server</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exclusion from test jar should be fine as its only minor version changes. Usually netty 4.1.x series is backward compatible.

@abstractdog
Copy link
Contributor

the latest on 4.1 line now is 4.1.130.Final, can you please check if it works too? if so, we can use it I believe

@Aggarwal-Raghav
Copy link
Contributor Author

the latest on 4.1 line now is 4.1.130.Final, can you please check if it works too? if so, we can use it I believe

Checking. I'll try to run some sample query on hive master branch as well to do a sanity check with netty-4.1.130

- Exclusion of netty dependency from hadoop-common test-jar dependency
@Aggarwal-Raghav Aggarwal-Raghav changed the title TEZ-4655: Upgrade Upgrade to netty 4.1.128.Final TEZ-4655: Upgrade Upgrade to netty 4.1.130.Final Jan 22, 2026
@Aggarwal-Raghav
Copy link
Contributor Author

Tested with hive as well (basic insert) without TEZ-4007 changes. With that it was stuck. Updated the PR descriptions as well

I have gone through that interesting feature (TEZ-4007) and have some excited questions about it, will ask them separately

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 9m 12s master passed
+1 💚 compile 1m 25s master passed
+1 💚 javadoc 1m 5s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 54s the patch passed
+1 💚 codespell 0m 59s No new issues.
+1 💚 compile 1m 23s the patch passed
+1 💚 javac 1m 23s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 javadoc 0m 43s the patch passed
_ Other Tests _
+1 💚 unit 59m 9s root in the patch passed.
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
78m 43s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/2/artifact/out/Dockerfile
GITHUB PR #442
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile
uname Linux b7b2c5b0013b 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-442/src/.yetus/personality.sh
git revision master / e04b68c
Default Java Ubuntu-21.0.9+10-Ubuntu-124.04
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/2/testReport/
Max. process+thread count 1374 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-442/2/console
versions git=2.43.0 maven=3.8.7 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog self-requested a review January 22, 2026 13:33
@abstractdog
Copy link
Contributor

abstractdog commented Jan 22, 2026

precommit is green, this is ready to merge
fixing possible problems after TEZ-4007 is a different thing

@abstractdog abstractdog merged commit ec3f0ef into apache:master Jan 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants