-
Notifications
You must be signed in to change notification settings - Fork 440
TEZ-4655: Upgrade Upgrade to netty 4.1.130.Final #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
| <artifactId>jersey-server</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <groupId>io.netty</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exclusion from test jar should be fine as its only minor version changes. Usually netty 4.1.x series is backward compatible.
|
the latest on 4.1 line now is 4.1.130.Final, can you please check if it works too? if so, we can use it I believe |
Checking. I'll try to run some sample query on hive master branch as well to do a sanity check with netty-4.1.130 |
- Exclusion of netty dependency from hadoop-common test-jar dependency
1e3ee2c to
e04b68c
Compare
|
Tested with hive as well (basic insert) without TEZ-4007 changes. With that it was stuck. Updated the PR descriptions as well I have gone through that interesting feature (TEZ-4007) and have some excited questions about it, will ask them separately |
|
💔 -1 overall
This message was automatically generated. |
|
precommit is green, this is ready to merge |
Dependency Tree:
netty-changes-dependency-tree.txt