Add tests to verify tomcat functions properly when clustering JARs are not present at runtime - #1038
Open
csutherl wants to merge 1 commit into
Open
Add tests to verify tomcat functions properly when clustering JARs are not present at runtime#1038csutherl wants to merge 1 commit into
csutherl wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
csutherl
force-pushed
the
no-clustering-tests
branch
from
August 8, 2026 02:28
05478e5 to
28bc4fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change follows up on 91ac751 and a few other recent commits which make cluster classloading fully dynamic by using reflection to handle clustering classes that are missing at runtime. These tests verify that tomcat work correctly when
catalina-ha.jarandcatalina-tribes.jarare not present using filtering classloaders to simulate that environment.The tests cover:
addClusterRuleSet()logs instead of failing)sessionsList.jsp: The Manager app sessions page compiles and renders without clustering, exercising the reflection-based fallback from 91ac751StoreConfigclasses load without error;clusterValveClassfields are null when clustering is absentStoreRegistry.getInterfaces(): Returns only the 10 core interfaces (no clustering interfaces) when clustering classes are not on the classpathEach test uses a custom classloader (
NoClusterClassLoaderorStoreConfigIsolatingClassLoader) that throws aClassNotFoundExceptionfororg.apache.catalina.ha.*andorg.apache.catalina.tribes.*packages.They're just a tests but I'm submitting this PR for some feedback since it's a bit of a hacky solution before committing.