[XERCESJ-1689] Xerces no longer bundles HTMLDOMImplementation#16
Merged
elharo merged 4 commits intoapache:mainfrom Nov 25, 2025
Merged
[XERCESJ-1689] Xerces no longer bundles HTMLDOMImplementation#16elharo merged 4 commits intoapache:mainfrom
elharo merged 4 commits intoapache:mainfrom
Conversation
elharo
changed the title
elharo
changed the title
elharo
changed the title
SingingBush
reviewed
Nov 25, 2025
Contributor
SingingBush
left a comment
SingingBush
left a comment
There was a problem hiding this comment.
there are x4 places in build.xml that will need HTMLDOMImplementation to be removed.
Worth noting that XERCESJ-1706 also mentions this and has a PR on the xerces2-j repo.
SingingBush
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The various classes were removed from the jars some time ago. They've been in the JDK since at least Java 1.4. HTMLDOMImplementation.class is no longer bundled in 2.12.3 though it was in 2.12.2. It's worth noting that org.w3c.dom.html was bundled in OpenJDK 1.8 (as I verified by looking inside rt.jar) but did not appear in the official JavaDoc until JDK 11 (or maybe 9).
See commit 13826ae which removed the source code but left the build instructions behind. This PR finishes up by removing a reference to HTMLDOMImplementation from build.xml