Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ Authors:
<echo message=" jars-schema11 --> 'jars' + XML Schema 1.1 support"/>
<echo message=" xjavac-jar --> generates the xjavac.jar file"/>
<echo message=" docs --> generates the HTML documentation"/>
<echo message=" javadocs --> generates the API docs (needs Java 1.2 or higher)"/>
<echo message=" javadocs --> generates the API docs"/>
<echo message=" samples --> compiles the samples source code"/>
<echo message=" compile --> compiles the source code"/>
<echo message=" deprecatedjar --> generates the xerces.jar file"/>
Expand Down Expand Up @@ -539,7 +539,7 @@ Authors:
bottom='${copyright}'
additionalparam='-quiet ${additional.param}'
>
<arg value="-Xdoclint:html,accessibility"/>
<arg value="-Xdoclint:none"/>
</javadoc>
<mkdir dir='${build.dir}/docs/javadocs/xs'/>
<javadoc packagenames='org.apache.xerces.xs, org.apache.xerces.xs.datatypes'
Expand All @@ -551,7 +551,7 @@ Authors:
bottom='${copyright}'
additionalparam='-quiet ${additional.param}'
>
<arg value="-Xdoclint:html"/>
<arg value="-Xdoclint:none"/>
</javadoc>

<mkdir dir='${build.dir}/docs/javadocs/xerces2'/>
Expand All @@ -573,7 +573,7 @@ Authors:
additionalparam='-quiet ${additional.param}'
>
<!-- The org.apache.xerces packages are the ones that need the most attention -->
<arg value="-Xdoclint:html,missing"/>
<arg value="-Xdoclint:none"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting -Xdoclint:none for javax.xml.*,org.w3c.*,org.xml.* is reasonable but for the packages under org.apache.xerces it should really be -Xdoclint:all (perhaps -Xdoclint:all -Xdoclint:-missing is reasonable).

Also it would be preferable to set the following on the xerces code:

      failonerror='yes'
      failonwarning='yes'

these Javadoc issues can be resolved with minimal effort. A lot of the errors are just invalid html in classes like EncodingMap. As for the warnings, as long as publicly accessible methods have all params and return values documented then it should be acceptable. Potentially failonwarning could be no as long as those things are covered

</javadoc>
<mkdir dir='${build.dir}/docs/javadocs/other'/>
<javadoc packagenames='org.apache.html.*,
Expand All @@ -585,8 +585,8 @@ Authors:
windowtitle='Other Classes' doctitle='Other Classes'
bottom='${copyright}'
additionalparam='-quiet ${additional.param}'
>
<arg value="-Xdoclint:html"/>
>
<arg value="-Xdoclint:none"/>
</javadoc>
</target>

Expand All @@ -612,7 +612,6 @@ Authors:
/>
</copy>


<copy todir="${distsrc.dir}/data" >
<fileset
dir="${data.dir}"
Expand Down