Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix DuckDB SQL injection vulnerability in adapter - #113

Open
aperetti wants to merge 1 commit into
mainfrom
jules-duckdb-sql-injection-fix-8668451605904462662
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix DuckDB SQL injection vulnerability in adapter#113
aperetti wants to merge 1 commit into
mainfrom
jules-duckdb-sql-injection-fix-8668451605904462662

Conversation

@aperetti

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: SQL Injection in DuckDB via f-string query construction in backend/src/shared/meter_adapters/duckdb_adapter.py. User-supplied timestamp inputs were directly interpolated into SQL commands (e.g., f"... WHERE r.timestamp >= '{st_lit}'::TIMESTAMP").
🎯 Impact: Exploitation could allow arbitrary execution of DuckDB queries, leading to data exposure, modification, or potentially system disruption within the local DuckDB session context.
πŸ”§ Fix:

  1. Replaced f-string interpolation with DuckDB's parameterized query placeholders (?::TIMESTAMP).
  2. Updated all conn.execute and EXPLAIN ANALYZE calls to explicitly pass parameter lists [start_time, end_time].
  3. Updated the test_duckdb_adapter.py test suite to assert the presence of parameterized placeholders and correctly formatted parameters.

βœ… Verification:

  1. Ran the backend tests suite successfully using cd backend && PYTHONPATH=. PARQUET_DIR=../data python3 -m pytest tests/test_duckdb_adapter.py.
  2. Verified all tests passed ensuring regressions were not introduced.

PR created automatically by Jules for task 8668451605904462662 started by @aperetti

…pter

Co-authored-by: aperetti <482392+aperetti@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant