π‘οΈ Sentinel: [CRITICAL] Fix DuckDB SQL injection vulnerability in adapter - #113
π‘οΈ Sentinel: [CRITICAL] Fix DuckDB SQL injection vulnerability in adapter#113aperetti wants to merge 1 commit into
Conversation
β¦pter Co-authored-by: aperetti <482392+aperetti@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: SQL Injection in DuckDB via f-string query construction in
backend/src/shared/meter_adapters/duckdb_adapter.py. User-supplied timestamp inputs were directly interpolated into SQL commands (e.g.,f"... WHERE r.timestamp >= '{st_lit}'::TIMESTAMP").π― Impact: Exploitation could allow arbitrary execution of DuckDB queries, leading to data exposure, modification, or potentially system disruption within the local DuckDB session context.
π§ Fix:
?::TIMESTAMP).conn.executeandEXPLAIN ANALYZEcalls to explicitly pass parameter lists[start_time, end_time].test_duckdb_adapter.pytest suite to assert the presence of parameterized placeholders and correctly formatted parameters.β Verification:
cd backend && PYTHONPATH=. PARQUET_DIR=../data python3 -m pytest tests/test_duckdb_adapter.py.PR created automatically by Jules for task 8668451605904462662 started by @aperetti