Skip to content

Clean up resp_tidy() #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonthegeek merged 1 commit into from
May 11, 2026
Merged

Clean up resp_tidy() #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Imports:
curl,
fs,
glue,
httr2 (>= 1.0.0),
httr2 (>= 1.1.0),
jsonlite,
lifecycle,
purrr,
Expand Down
12 changes: 2 additions & 10 deletions R/resp_tidy.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ resp_tidy <- function(resps) {

#' @export
resp_tidy.httr2_response <- function(resps) {
# TODO: Replace this with httr2::resp_request() after
# https://github.com/r-lib/httr2/pull/615
req <- resps$request
req <- httr2::resp_request(resps)
if (length(req$policies$resp_tidy)) {
return(
rlang::exec(
Expand All @@ -66,13 +64,7 @@ resp_tidy.list <- function(resps) {
class(resps) <- c("nectar_responses", "list")
return(resp_tidy(resps))
}
.nectar_abort(
c(
"No method is available to {.fn nectar::resp_tidy} this object.",
i = "You might want to try {.fn nectar::resp_parse} instead."
),
"unsupported_response_class"
)
NextMethod()
}

#' @export
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/resp_tidy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@
<error/nectar-error-unsupported_response_class>
Error in `resp_tidy()`:
! No method is available to `nectar::resp_tidy()` this object.
i You might want to try `nectar::resp_parse()` instead.
i `nectar::resp_tidy()` expects <httr2_response> objects, or lists thereof.

Loading