chore: bump apisix-nginx-module to 1.19.4#459
Conversation
This version adds upstream state FFI functions that allow Lua code to populate nginx upstream variables ($upstream_status, $upstream_addr, $upstream_response_time, etc.) when the upstream module is bypassed by cosocket-based transports (e.g., ai-proxy plugin).
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the APISIX runtime build script to use the newer apisix-nginx-module release, aligning the runtime build with upstream 1.19.4 features (notably the upstream state FFI functions mentioned in the PR description).
Changes:
- Bump
apisix_nginx_module_verfrom1.19.3to1.19.4in the runtime build script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@build-apisix-runtime.sh`:
- Line 27: Two build scripts diverge on the apisix-nginx-module version: the
variable apisix_nginx_module_ver in build-apisix-runtime.sh is set to "1.19.4"
while build-apisix-base.sh pins "1.18.0", which will produce different binaries;
decide whether the version split is intentional and either (a) synchronize both
scripts to the same version by updating the apisix_nginx_module_ver value in one
script to match the other, or (b) if the divergence is intentional (e.g.,
separate release tracks), add an explicit comment next to
apisix_nginx_module_ver in both build-apisix-runtime.sh and build-apisix-base.sh
explaining the reason and linking to the relevant release policy or issue number
for future maintainers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d00678df-5992-41e3-b5ff-bb7303b96ace
📒 Files selected for processing (1)
build-apisix-runtime.sh
Bump
apisix-nginx-modulefrom 1.19.3 to 1.19.4.What's new in 1.19.4
Adds upstream state FFI functions (
push_upstream_state/update_upstream_state) that allow Lua code to populate nginx upstream variables (`$upstream_status`, `$upstream_addr`, `$upstream_response_time`, `$upstream_header_time`, `$upstream_connect_time`, `$upstream_response_length`) when the upstream module is bypassed by cosocket-based transports (e.g., ai-proxy plugin).See: api7/apisix-nginx-module#112
Summary by CodeRabbit
apisix-nginx-moduledependency to version1.19.4.