Skip to content

chore: bump apisix-nginx-module to 1.19.4#459

Merged
nic-6443 merged 1 commit into
masterfrom
nic/bump-nginx-module-1.19.4
Apr 29, 2026
Merged

chore: bump apisix-nginx-module to 1.19.4#459
nic-6443 merged 1 commit into
masterfrom
nic/bump-nginx-module-1.19.4

Conversation

@jarvis9443
Copy link
Copy Markdown
Contributor

@jarvis9443 jarvis9443 commented Apr 28, 2026

Bump apisix-nginx-module from 1.19.3 to 1.19.4.

What's new in 1.19.4

Adds upstream state FFI functions (push_upstream_state / update_upstream_state) that allow Lua code to populate nginx upstream variables (`$upstream_status`, `$upstream_addr`, `$upstream_response_time`, `$upstream_header_time`, `$upstream_connect_time`, `$upstream_response_length`) when the upstream module is bypassed by cosocket-based transports (e.g., ai-proxy plugin).

See: api7/apisix-nginx-module#112

Summary by CodeRabbit

  • Chores
    • Updated apisix-nginx-module dependency to version 1.19.4.

This version adds upstream state FFI functions that allow Lua code to
populate nginx upstream variables ($upstream_status, $upstream_addr,
$upstream_response_time, etc.) when the upstream module is bypassed
by cosocket-based transports (e.g., ai-proxy plugin).
Copilot AI review requested due to automatic review settings April 28, 2026 08:52
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

📝 Walkthrough

Walkthrough

The build-apisix-runtime.sh script's apisix-nginx-module dependency version is updated from 1.19.3 to 1.19.4, affecting the git branch/tag checkout and module sources during OpenResty configuration.

Changes

Cohort / File(s) Summary
Dependency Version Update
build-apisix-runtime.sh
Pins apisix-nginx-module version to 1.19.4, changing the module checkout and configuration sources during OpenResty build.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • nic-6443
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: bump apisix-nginx-module to 1.19.4' directly and accurately reflects the main change in the pull request, which is updating the apisix-nginx-module dependency from version 1.19.3 to 1.19.4.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
E2e Test Quality Review ✅ Passed The E2E Test Quality Review check is not applicable to this pull request as it is a build script maintenance change updating dependency version in build-apisix-runtime.sh, not a test code change.
Security Check ✅ Passed PR modifies only build-apisix-runtime.sh line 27, changing apisix_nginx_module_ver from 1.19.3 to 1.19.4. No security vulnerabilities found across all seven security categories: no sensitive data exposure, no unencrypted secrets, no authorization bypass, no resource access issues, no cryptographic configuration errors, no resource isolation conflicts, and no improper secret references.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nic/bump-nginx-module-1.19.4

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the APISIX runtime build script to use the newer apisix-nginx-module release, aligning the runtime build with upstream 1.19.4 features (notably the upstream state FFI functions mentioned in the PR description).

Changes:

  • Bump apisix_nginx_module_ver from 1.19.3 to 1.19.4 in the runtime build script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@build-apisix-runtime.sh`:
- Line 27: Two build scripts diverge on the apisix-nginx-module version: the
variable apisix_nginx_module_ver in build-apisix-runtime.sh is set to "1.19.4"
while build-apisix-base.sh pins "1.18.0", which will produce different binaries;
decide whether the version split is intentional and either (a) synchronize both
scripts to the same version by updating the apisix_nginx_module_ver value in one
script to match the other, or (b) if the divergence is intentional (e.g.,
separate release tracks), add an explicit comment next to
apisix_nginx_module_ver in both build-apisix-runtime.sh and build-apisix-base.sh
explaining the reason and linking to the relevant release policy or issue number
for future maintainers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d00678df-5992-41e3-b5ff-bb7303b96ace

📥 Commits

Reviewing files that changed from the base of the PR and between df1e411 and b89b77f.

📒 Files selected for processing (1)
  • build-apisix-runtime.sh

Comment thread build-apisix-runtime.sh
@nic-6443 nic-6443 merged commit 1df8237 into master Apr 29, 2026
11 checks passed
@nic-6443 nic-6443 deleted the nic/bump-nginx-module-1.19.4 branch April 29, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants