feat(only-and-omit): pick or exclude actors - #108
Merged
Conversation
ruocco-l
approved these changes
Aug 5, 2026
ruocco-l
left a comment
ruocco-l
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with it. The fact that e-commerce already have this problem and just adding this fix it is a sign that can be useful in multiple workflows (the build from local selection is a similar example). Thanks!
| */ | ||
| export const actorSelectionOptions = <T>(y: Argv<T>) => { | ||
| return y | ||
| .option('actors', { |
Contributor
There was a problem hiding this comment.
NIT: I'd rather call these --include-actors and --omit-actors
Contributor
Author
There was a problem hiding this comment.
only went by these since local build already used --actors.
Can change it if needed tho, i don't really care either way
metalwarrior665
approved these changes
Aug 6, 2026
metalwarrior665
left a comment
metalwarrior665
left a comment
Member
There was a problem hiding this comment.
Looks generally useful (since we want to open this more to public) and low maintenance overhead. Ideally rebase it later so that this is separate commit to master after the breaking one from Luigi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added
--omit-actorsand--only-actorsto ignore or focus on certain actors.Purpose is to enable the 2 step deployment process of POD E.
pod e needs:
Even if not needed for this case, added both as arrays. So it can be used as:
--omit-actors actor1 actor2 actor3 ...Also the filtering function asserts all being found on the config. Since there is probably something wrong if your options don't match your config.
This is the most versatile thing i cooked up and then the responsibility of the ordering and such falls on the deployment action workflow. Which in this case would be: