Skip to content

fix: make RequestQueueClient.is_finished abstract #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aryansk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: make RequestQueueClient.is_finished abstract #2165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/crawlee/storage_clients/_base/_request_queue_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,20 +125,12 @@ async def is_empty(self) -> bool:
True if the request queue is empty, False otherwise.
"""

@abstractmethod
async def is_finished(self) -> bool:
"""Check if the request queue is finished.

A finished queue is empty and has no requests currently being processed.

Warning:
This default only checks `is_empty`, which reports whether requests are available to fetch, not
whether requests are still being processed. It can therefore return `True` while requests are in
progress. Subclasses that track in-progress requests should override this method; all built-in
clients already do.

Returns:
True if the request queue is finished, False otherwise.
"""
# TODO: Make this method abstract.
# https://github.com/apify/crawlee-python/issues/1985
return await self.is_empty()