fix: route robots.txt through proxy and apply MITM TLS per proxy URL - #3940
Open
Ayush7614 wants to merge 2 commits into
Open
fix: route robots.txt through proxy and apply MITM TLS per proxy URL#3940Ayush7614 wants to merge 2 commits into
Ayush7614 wants to merge 2 commits into
Conversation
respectRobotsTxtFile fetched robots.txt without the crawler proxy, leaking the real IP and missing geo-specific rules. Also MITM TLS disabling was configuration-wide, so mixed MITM and normal proxies shared one incorrect setting. Fetch robots via ProxyConfiguration and gate rejectUnauthorized / ignoreHTTPSErrors on the selected proxy URL.
Ayush7614
force-pushed
the
fix/proxy-aware-robots-and-mitm
branch
from
July 30, 2026 14:52
fde58d3 to
827a6e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
respectRobotsTxtFilefetched robots.txt without the crawler proxy, leaking the real IP and missing geo-specific robots rules.ProxyConfiguration, addmanInTheMiddleProxyUrls/isProxyManInTheMiddle, and gaterejectUnauthorized/ignoreHTTPSErrorson the selected proxy URL.Test plan
yarn test test/core/proxy_configuration.test.tsyarn test test/core/crawlers/basic_crawler.test.ts -t "fetches robots.txt through"