fix(core): accept the documented requestManager crawler option - #4030
Open
NotAFlightRisk wants to merge 1 commit into
Open
fix(core): accept the documented requestManager crawler option#4030NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went to share a queue between two crawlers, found
requestManagerin theBasicCrawlerOptionsdocs, and passing it throws before anything runs:The key just isn't in
optionsShape, andow.object.exactShapeis the first thing the constructor does - so the handling below it, including the "cannot be used in conjunction withrequestListand/orrequestQueue" error, is unreachable. No way round it short of subclassing.Borrowed the validator key list from the one on
v4so the two branches agree. Every subclass spreadsoptionsShape, so this covers Cheerio/ Playwright/ Puppeteer/ JSDOM/ HTTP too.Happy to drop the
validatorsentry and use a plainow.optional.objectif you'd rather keep the diff to one line.