Conversation
Similar to what we do for `uv`, this will persist pre-commit hooks and make it so they don't need to be re-initialized everytime the container is rebuilt.
Add docker volume for pre-commit cache
Add create_test_user management command
Don't use django setting to store allowed schema versions
* feat: have the `/info/` endpoint provide instance config info * test: update `test_rest_info()` To include the output of instance config value * tmp: temporarily set the dandischema dependency to the devendorize branch * test: provide env var to set schema config instance name * feat: make dandischema instance config available through Django settings * feat: provide instance name through dandischema instance config instead of a hardcoded value * feat: provide instance name through dandischema instance config instead of a hardcoded value * feat: replace `"DANDI` with instance name in `DandisetList` vue component * ci: add DJANGO_DANDI_INSTANCE_NAME env var to frontend CI * feat: replace hardcoded RRID with one set in schema instance config * ci: add instance identifier to backend CI env * feat: replace the use of hardcoded license * feat: use dandiarchive's version in producing `PublishActivity` metadata Per @yarikoptic this is an improvement over the hardcoded '0.1.0' * feat: vendorize software name in `PublishActivity` metadata * test: update tests for the `PublishActivity` metadata changes * style: replace use of `dandiapi.__version__` with `importlib.metadata.version` Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com> * rf: remove outdated patching of JSON schema For discussion about this removal, see dandi#2584 (comment) for details * style: replace use of `dandiapi.__version__` with `importlib.metadata.version` in tests * rf: import `dandischema.conf.get_instance_config` as `get_schema_instance_config` Importing the function under this name emphasizes the returned config pertains to dandischema and its usage * feat: call avoid using `dandiapi/settings/base.py` to store schema instance config `dandiapi/settings/base.py` is reserved for used for configuring settings, possibly for the Django app alone. See dandi#2584 (comment) for rationale for the change. * revert: revert naming of API service in generated asset metadata * Always use first sorted license value in create_dev_dandiset * Don't rename `get_instance_config` to `get_schema_instance_config` * Don't use global variables for instance config * Reuse identical schema object for tests * Require DJANGO_DANDI_INSTANCE_IDENTIFIER env var * Use dummy instance config values for local dev and CI * Revert change of version value in PublishableMetadataMixin * Update tests regarding Pydantic and None values This more directly tests the issue we care about. As it was written, the test could still pass unintentionally, if the default values were the same as the values we had set them to. * Require DJANGO_DANDI_DOI_API_PREFIX env var * Use schema vendorization for DOIs * Use schema vendorization for id/identifier * Revert unnecessary change to `$route.query` * Use function to supply default license value * Fix linting errors * Fix malformed license field in create_dev_dandiset * Move `get_default_license` to conftest.py and rename * Set dandischema dependency to 0.12.0 --------- Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com> Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Simply import `DANDI_SCHEMA_VERSION` from dandischema.consts
Auto approve users from McGill University
141 Sync (Week of Nov. 24) -> prod
Remove `DANDI_SCHEMA_VERSION` as a setting
Removes the need for the mitigation in migrate_version_metadata Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Update management command for schema migration
Empty commit for release
Update sync branch (Dec. 22 Week)
15 tasks
✅ Deploy Preview for ember-dandi-archive ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
laurendiaz
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO!
After merging, run
python manage.py migrate_version_metadata --allin Heroku