Approve late/unofficial submissions when adding deviations#1029
Draft
markkuriekkinen wants to merge 2 commits intoapluslms:masterfrom
Draft
Approve late/unofficial submissions when adding deviations#1029markkuriekkinen wants to merge 2 commits intoapluslms:masterfrom
markkuriekkinen wants to merge 2 commits intoapluslms:masterfrom
Conversation
TODO: * +1 max submissions deviation button in the inspect submission view: should this also check if any submission should be approved immediately? * test all the changes * deviations/viewbase.py approve_unofficial_submissions(): implementation unfinished * clean up the code * success messages to the user in the user interface? When deviations are added, the teacher may choose to also immediately approve such existing submissions that are covered by the deviation. For example, if the submission was late, but with the new personal deadline it is not late, then it would be approved. Fixes apluslms#892. "The second pull request" in the comment: apluslms#892 (comment) This work started in Muhammad's pull request apluslms#991. Markku has refactored the code, improved the database queries and the details overall. Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
This was referenced May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work-in-progress draft as a reminder: Approve late/unofficial submissions when adding deviations
TODO:
should this also check if any submission should be approved immediately?
When deviations are added, the teacher may choose to also immediately
approve such existing submissions that are covered by the deviation.
For example, if the submission was late, but with the new personal
deadline it is not late, then it would be approved.
Fixes #892.
"The second pull request" in the comment:
#892 (comment)
This work started in Muhammad's pull request #991. Markku has
refactored the code, improved the database queries and the details
overall.
Co-authored-by: Muhammad Wahjoe faiz00.muhammad@gmail.com
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!