Skip to content

Fix user tagging for a single course participant.#1506

Merged
ihalaij1 merged 2 commits intoapluslms:masterfrom
sayravai:fix_user_tagging_v2
Mar 5, 2026
Merged

Fix user tagging for a single course participant.#1506
ihalaij1 merged 2 commits intoapluslms:masterfrom
sayravai:fix_user_tagging_v2

Conversation

@sayravai
Copy link
Contributor

Description

Fix multiple issues with adding and removing user tags when on the single participants' page (/teachers/participants/x):

  • Added tags did not appear on the page immediately due to js errors
  • Removed tags did not appear on the "Add new tagging" dropdown menu (this feature was not present but now added)
  • Used the aplus-button styling with the "xs" variant to more closely match the action buttons to the tags in the user_results.html template. This also allows keyboard navigation to work properly for the dropdown.

NOTE: This update also needs a patch to django-colortag to support adding custom css classes ("btn aplus-button--default aplus-button--xs") for the dropdown button.

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1 ihalaij1 force-pushed the fix_user_tagging_v2 branch from 216f0d6 to f657173 Compare March 5, 2026 15:02
@ihalaij1 ihalaij1 self-requested a review March 5, 2026 15:48
Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I tested this and made some minor changes.

@ihalaij1 ihalaij1 merged commit 2ed9758 into apluslms:master Mar 5, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants