Allow setting host path with command line arguement, with environment variable and with roman config#8
Open
JohnDing1995 wants to merge 1 commit intoapluslms:milestone0.4from
Open
Conversation
JohnDing1995
force-pushed
the
milestone0.3
branch
from
8f14440 to
e3aab54
Compare
JohnDing1995
changed the title
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
raphendyr
reviewed
Jun 5, 2019
JohnDing1995
force-pushed
the
milestone0.3
branch
from
994905c to
2d3c8b7
Compare
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
raphendyr
reviewed
Jun 10, 2019
JohnDing1995
force-pushed
the
milestone0.3
branch
2 times, most recently
from
ccaa7c5 to
fd2d132
Compare
raphendyr
reviewed
Jun 11, 2019
JohnDing1995
force-pushed
the
milestone0.3
branch
3 times, most recently
from
6502a84 to
8d2ea71
Compare
JohnDing1995
force-pushed
the
milestone0.3
branch
13 times, most recently
from
1951da7 to
576042b
Compare
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
raphendyr
reviewed
Jul 12, 2019
…nd host mechine * Set the path mapping with global config *.yml file * If the mapping is not set on global config file, try to read the mapping from environment variable.
JohnDing1995
force-pushed
the
milestone0.3
branch
from
c898a12 to
7ae4607
Compare
Contributor
|
After a long though, I have come to conclusion. I think we will move forward with creating a volume, then uploading the course material to the volume and running the builds. To speed up this in iterative builds, we can use librsync or similar to upload only changed files. Thus, before closing this PR, we need to:
In addition, we will look into implementing the volume stuff. Until that, the current system works for local building (the currently supported usecase). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell docker back-end the location of source file on host machine(if running roman on a container)
The priority order is