chore: Re-export config types - #32
Merged
Merged
Conversation
isaacs
approved these changes
Jul 15, 2026
|
|
||
| const moduleDetailsFromPath: (filepath: string) => ModuleDetails = | ||
| (moduleDetailsFromPathImport as any).default || | ||
| (moduleDetailsFromPathImport as any); |
Contributor
There was a problem hiding this comment.
This seems like a worthwhile cleanup, but I'm curious why it was like that in the first place. Did it used to not have a default export or something?
Member
Author
There was a problem hiding this comment.
I fixed a similar issue here but with a different Rollup setting.
This time chaging the Rollup exports setting to auto fixes the ESM interop issue:
https://github.com/apm-js-collab/code-transformer-bundler-plugins/pull/32/changes#diff-6a3b01ba97829c9566ef2d8dc466ffcffb4bdac08706d3d6319e42e0aa6890dd
Contributor
There was a problem hiding this comment.
Ah, esm interop. Makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives easy access to the types without needing
@apm-js-collab/code-transformeras a dependency.Because we now export
./core, this fixes another issue where consumers can't accessCodeTransformerPluginOptions.