bump dep, don't work with Node.js ^21.0.0 fix #580#612
Merged
apotdevin merged 1 commit intoapotdevin:masterfrom May 21, 2024
Merged
bump dep, don't work with Node.js ^21.0.0 fix #580#612apotdevin merged 1 commit intoapotdevin:masterfrom
apotdevin merged 1 commit intoapotdevin:masterfrom
Conversation
|
hey @apotdevin I would love to help review a couple of PRs including this one to take some work off your hands and also give a second opinion. does this possibility work for you? |
apotdevin
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThunderHub does not work with
nodejs^21.0.0 due toechartsdependency which at the same time had an issue with itszrenderdependency.echarts: issuezrender: upstream prSolved on
zrender^5.5.0, bump deps onecharts^5.5.0Issue description on #580