-
-
Notifications
You must be signed in to change notification settings - Fork 254
feat: Adopt AGP v9 #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Adopt AGP v9 #733
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c9877b9
feat: ugprade Gradle version
hurali97 40b53bb
feat: enable opt outs
hurali97 aece6c9
feat: adopt agp v9 with backward compat
hurali97 812d8a7
fix: patch RNGP for example app
hurali97 262c63f
fix: apply formatting
hurali97 bc8ae83
revert: kotlin and gradle version changes for example app
hurali97 493637f
docs: update version matrix
hurali97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,8 @@ buildscript { | |
|
|
||
| dependencies { | ||
| classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version") | ||
| classpath("com.android.tools.build:gradle:7.3.1") | ||
| classpath("com.diffplug.spotless:spotless-plugin-gradle:6.11.0") | ||
| classpath("com.android.tools.build:gradle:9.2.1") | ||
| classpath("com.diffplug.spotless:spotless-plugin-gradle:8.1.0") | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -32,7 +32,23 @@ def isNewArchitectureEnabled() { | |
| } | ||
|
|
||
| apply plugin: 'com.android.library' | ||
| apply plugin: 'kotlin-android' | ||
|
|
||
|
|
||
| def shouldEnableAgpFallback() { | ||
| def agpMajorVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger() | ||
| if (agpMajorVersion <= 8) { | ||
| return true | ||
| } | ||
|
|
||
| def propertyVal = providers.gradleProperty("android.builtInKotlin").orNull | ||
| def isBuiltInKotlinEnabled = propertyVal != null ? propertyVal.toBoolean() : true | ||
|
|
||
| return !isBuiltInKotlinEnabled | ||
| } | ||
|
|
||
| if (shouldEnableAgpFallback()) { | ||
| apply plugin: 'kotlin-android' | ||
| } | ||
|
|
||
| if (isNewArchitectureEnabled()) { | ||
| apply plugin: "com.facebook.react" | ||
|
|
@@ -82,17 +98,11 @@ android { | |
| exclude "**/libreact_render*.so" | ||
| } | ||
| sourceSets.main { | ||
| java { | ||
| if (isNewArchitectureEnabled()) { | ||
| srcDirs += [ | ||
| "src/fabric/java", | ||
| "${project.buildDir}/generated/source/codegen/java" | ||
| ] | ||
| } else { | ||
| srcDirs += [ | ||
| "src/paper/java" | ||
| ] | ||
| } | ||
| if (isNewArchitectureEnabled()) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you update |
||
| java.directories.add("${project.buildDir}/generated/source/codegen/java") // contains only java files | ||
| kotlin.directories.add("src/fabric/java") // contains only kotlin files | ||
| } else { | ||
| kotlin.directories.add("src/paper/java") // contains both java and kotlin files | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
hurali97 marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,5 +2,5 @@ package com.th3rdwave.safeareacontext | |
|
|
||
| enum class SafeAreaViewMode { | ||
| PADDING, | ||
| MARGIN | ||
| MARGIN, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hurali97 marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.