fix: resolve ProxyBuilderImpl ClassNotFoundException in parallel import#1
Open
fix: resolve ProxyBuilderImpl ClassNotFoundException in parallel import#1
Conversation
adhurjaty
force-pushed
the
fix-class-loading-parallel
branch
2 times, most recently
from
c3df231 to
a883566
Compare
…s/actions/download-artifact-7.0.0 build(deps): bump actions/download-artifact from 4.1.8 to 7.0.0
Feat/empty array delete
…n_1384 feat: get all clients by page of 100 adorsys#1384
…redentialsFlow_1387 Allow to change default reset credentials flow adorsys#1387
…s/actions/cache-5.0.3 build(deps): bump actions/cache from 4.2.0 to 5.0.3
…k-in-logs added turbo filter to sanitize wire log messages
Fix/client policies erasure
adhurjaty
force-pushed
the
fix-class-loading-parallel
branch
from
35f8a02 to
963d55e
Compare
When "remote state" is enabled for clients (the default), Keycloak will only delete clients that were listed in the config tool's state. This prevents it from deleting clients that it didn't create. When deciding what to delete, we can just fetch the clients that were already in the state, rather than listing all the clients in the realm. This should be a much smaller list, and prevents issues where the server cuts off the response when the list is too large.
It's difficult to avoid all situations where we need to list all the clients in the realm. If we try fetching them all in one request, it can fail because the response is cut off by the server. As long as we're using reasonably-sized pages, we should avoid resource limits and actually run much faster.
Previously, searchByName() was fetching all groups and filtering. This now uses `?search=<name>&exact=true`. There is still another place where it is fetching all groups. For now, we'll add pagination, but eventually we'll want to fix this.
…emains the same) (#15)
…t long-running query (#17)
Signed-off-by: Anil Dhurjaty <anil.dhurjaty@appfolio.com>
adhurjaty
force-pushed
the
fix-class-loading-parallel
branch
from
963d55e to
1aa3cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly set the class loader in all threads to be the application class loader (not system)
Kind of like this error but that one is supposedly resolved