Port tvOS headers#141
Closed
imurchie wants to merge 3 commits into
Closed
Conversation
| @@ -1,8 +1,8 @@ | |||
| # Used for HTTP routing | |||
| github "marekcirkos/RoutingHTTPServer" | |||
| github "shvul/RoutingHTTPServer" | |||
There was a problem hiding this comment.
I'd rather move this component to appium org
Author
There was a problem hiding this comment.
Me too. He has a fork of the Cocoa HTTP server too.
mykola-mokhnach
approved these changes
Feb 16, 2019
KazuCocoa
approved these changes
Feb 18, 2019
jlipps
approved these changes
Feb 18, 2019
Member
|
will we merge this? 👀 |
|
@imurchie I think these fixes to tests might look better if moved to a separate PR |
Member
|
i'm interested in this too, any more ideas @imurchie? |
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begin porting tvOS support into Appium fork. This covers facebookarchive#1032