Skip to content

Use log instead of print for system start status messages #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityabagchi24 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Use log instead of print for system start status messages #1889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/ContainerCommands/System/SystemStart.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ extension Application {
}

do {
print("Verifying machine API server is running...")
log.info("Verifying machine API server is running...")
_ = try await MachineClient().list()
} catch {
throw ContainerizationError(
Expand Down Expand Up @@ -174,7 +174,7 @@ extension Application {
private func installDefaultKernel(kernelURL: URL, kernelBinaryPath: String) async throws {
var shouldInstallKernel = false
if kernelInstall == nil {
print("No default kernel configured.")
log.warning("No default kernel configured.")
print("Install the recommended default kernel from [\(kernelURL)]? [Y/n]: ", terminator: "")
guard let read = readLine(strippingNewline: true) else {
throw ContainerizationError(.internalError, message: "failed to read user input")
Expand Down