Preserve fractional memory sizes across MemorySize encoding#1904
Open
anxkhn wants to merge 1 commit into
Open
Conversation
MemorySize.formatted computed Int64(measurement.value), truncating the fractional part while keeping the coarse unit, so a configured size such as "1.5gb" encoded to "1gb" (and "0.5gb" to "0gb"). Because MemorySize is the Codable persisted representation of container and machine memory config, the configured value did not survive an encode/decode (save and reload) cycle and memory was silently dropped. Emit the exact byte count when the value is fractional; binary units are integer multiples of a byte, so this keeps the round-trip lossless and leaves whole-number output unchanged. Add a fractional round-trip test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files changed
Sources/ContainerPersistence/MemorySize.swift(+10): guard informatted;when
measurement.valueis fractional, emit the exact integer byte count(
UInt64(measurement.converted(to: .bytes).value.rounded())+b) instead ofthe truncated coarse unit. Whole-number path untouched.
Tests/ContainerAPIClientTests/MemorySizeTests.swift(+9): addtestRoundTripEncodingFractional(parameterized over 4 fractional inputs).The diff (for reference)