Fix ArchiveReader to support readonly directory#716
Open
JaewonHur wants to merge 1 commit into
Open
Conversation
Contributor
|
Looks good, can you rebase? |
Defer attribute setting of directories so that we can unarchive child entries first, then apply attributes which might be read-only.
JaewonHur
force-pushed
the
fix-readonly-unarchive
branch
from
96483e4 to
77da467
Compare
Contributor
Author
|
@crosbymichael rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer attribute setting of directories so that we can unarchive child entries first, then apply attributes which might be read-only.