Skip to content

Generalized type validation - #1715

Merged
bioball merged 1 commit into
apple:mainfrom
HT154:general-type-validation
Jun 30, 2026
Merged

Generalized type validation#1715
bioball merged 1 commit into
apple:mainfrom
HT154:general-type-validation

Conversation

@HT154

@HT154 HT154 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

This builds on #1695, but extracts validation logic to a new abstract TypeNode subclass for reuse by #1698.

@HT154
HT154 force-pushed the general-type-validation branch 4 times, most recently from 3e72b42 to 766e925 Compare June 29, 2026 19:29
@HT154 HT154 changed the title General type validation Generalized type validation Jun 29, 2026
@HT154
HT154 force-pushed the general-type-validation branch 2 times, most recently from 413782b to afde921 Compare June 29, 2026 20:04

@bioball bioball left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some notes about final

Comment thread pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java Outdated
Comment thread pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java Outdated
Comment thread pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java Outdated
@HT154
HT154 force-pushed the general-type-validation branch from afde921 to 163814a Compare June 30, 2026 06:40
@HT154
HT154 force-pushed the general-type-validation branch from 163814a to e6360b2 Compare June 30, 2026 06:50

@stackoverflow stackoverflow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bioball
bioball merged commit bfa6a98 into apple:main Jun 30, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants