Split libpkl libraries between shared and static libs - #1812
Open
bioball wants to merge 9 commits into
Open
Conversation
This adds a `libpkl-static.pc` so pkg-config users can link either statically or dynamically via `pkg-config --libs libpkl`, or `pkg-config --libs libpkl-static`. Additionally, this fixes an issue where the replace tokens wasn't doing anything, leaving the `@version@` token intact in the archive. This also changes the format of the archive to put the static lib in its own subdirectory, and the shared lib in its own subdirectory.
bioball
commented
Aug 6, 2026
| ├── lib | ||
| │ ├── libpkl.<shared library extension> | ||
| │ ├── libpkl.<static library extension> | ||
| │ ├── libpkl.<dynamic library extension> |
Member
Author
There was a problem hiding this comment.
Unrelated: standardize on "shared library" instead of "dynamic library"
stackoverflow
approved these changes
Aug 6, 2026
Co-authored-by: Islon Scherer <islonscherer@gmail.com>
bioball
enabled auto-merge (squash)
August 6, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
libpkl-static.pcso pkg-config users can link either statically or dynamically viapkg-config --libs libpkl, orpkg-config --libs libpkl-static.Additionally, this fixes an issue where the replace tokens wasn't doing anything, leaving the
@version@token intact in the archive.[native-libpkl]