pkl.project: check symlink targets#173
Merged
Merged
Conversation
Contributor
Author
|
CI is red due to an unrelated issue that is being addressed by #170 |
The pkl module extension uses symlinks to refer to the PklProject and PklProject.deps.json files. The rctx.symlink function does not guarantee that the symlink points at a real file on the filesystem and it doesn't watch the file for changes. With this change, we ensure the file exists before symlinking to it and watch it for changes (in case it's deleted by the user).
malt3
force-pushed
the
ensure-symlink-target-exists
branch
from
c91e426 to
e28d0ca
Compare
sitaktif
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pkl module extension uses symlinks to refer to the PklProject and PklProject.deps.json files. The rctx.symlink function does not guarantee that the symlink points at a real file on the filesystem and it doesn't watch the file for changes.
With this change, we ensure the file exists before symlinking to it and watch it for changes (in case it's deleted by the user).