Conversation
|
Is there anything I can do to help with the failed checks? I have exactly this example with the correction running now in a private repo, talking to a local podman repository, responding to curl just fine. I can make it public if it will help. |
|
@carlynorama Thank you for noticing this! I'm sorry it's taken me a while to get back to you. Could you please update your PR to put back the
swift-container-plugin/Examples/HelloWorldWithResources/Package.swift Lines 22 to 25 in 9417b63 This happened because I had changed the example so that when I built it locally it would use the checked-out version of the plugin and let me test my work in progress changes. This was just a temporary change and I didn't intend to commit it. 🤦 The test is failing now because, without either the fully-qualified |
|
No worries about the delay! Did I do it right? |
|
The 6.2 test failure may be for the same reason as #158 - the GitHub runner isn't picking up the configuration change. Should pass when force-merged to main. |
Motivation
I believe the line
.package(path: "../.."),in thePackage.swiftof the Hummingbird example is vestigial from perhaps a previous version where it was just aPackage.swiftand amain.swift. If it is need explicitly for a container build, please mention in the docs because a regularswift buildto test the app locally doesn't work until it is removed.Modifications
removed the single line
.package(path: "../..")from thePackage.swiftin the Hummingbird example.Result
Example will now build to be tested pre-containerization test.
Test Plan
Don't believe change needs a test as the example already does not have tests.