Handle non-JSON error payloads gracefully#172
Merged
euanh merged 1 commit intoapple:mainfrom Feb 2, 2026
Merged
Conversation
Fixes #136 When a registry returns an error response with a non-JSON body (e.g., plain text like 'page not found'), ContainerRegistry now catches the DecodingError and throws a more informative RegistryClientError with the HTTP status code and raw response body, instead of propagating the confusing JSONDecoder error. Added new error case: - RegistryClientError.unexpectedRegistryResponse(status:body:) This provides clearer error messages when registries don't follow the OCI distribution spec for error responses.
euanh
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #136
When a registry returns an error response with a non-JSON body (e.g., plain text like "page not found" from
registry:2),ContainerRegistrynow handles this gracefully instead of propagating a confusingJSONDecodererror.Changes
RegistryClientError.unexpectedRegistryResponse(status:body:)executeRequestThrowingmethods to catchDecodingErrorwhen parsing error responsesBefore
After
Testing
The fix handles the case mentioned in #136 where opening an upload session with an invalid repository name causes
registry:2to respond with a 404 and plain text body "page not found".