Fix document filtering to handle references with description or summary fields#858
Merged
czechboy0 merged 3 commits intoapple:mainfrom Jan 13, 2026
Merged
Fix document filtering to handle references with description or summary fields#858czechboy0 merged 3 commits intoapple:mainfrom
czechboy0 merged 3 commits intoapple:mainfrom
Conversation
auto-merge was automatically disabled
January 13, 2026 13:53
Head branch was pushed to by a user without write access
czechboy0
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If OpenAPI document filtering is enabled for operations containing references with
descriptionorsummaryfields, Swift OpenAPI Generator fails with an error as such references cannot be resolved.For example, this reference can be resolved:
but not this one:
The cause of the described issue is in the
FilteredDocumentBuildercode. The required components are registered there, including optionaldescriptionandsummaryproperties, while the reference matching for filtering is done against references created only with component keys, so equality check fails ifdescriptionorsummaryare present.Modifications
Registering and matching only component keys instead of whole references.
Result
After this change, there are no more limitations on having description and summary fields for references in filtered operations.
Test Plan
Extended unit tests with test cases to cover the described issues:
/things/cpath that exercises references with descriptions across:The added tests fail without the fix.