Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes vertical spacing when creating columns in unit groups by modifying CSS custom properties to use two-value syntax for gap spacing. The change sets vertical gap to 0 while maintaining the existing horizontal gap.
Changes:
- Modified
--acms-gapand--acms-stack-spacingcustom properties from single-value to two-value syntax (vertical horizontal) in editor base styles - Applied changes consistently across both
siteandbeginnerthemes - Compiled CSS files include additional autoprefixer updates (vendor prefix removals and property reordering)
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| themes/site/src/scss/editor/_base.scss | Updated gap and stack spacing custom properties to set vertical spacing to 0 |
| themes/beginner/src/scss/editor/_base.scss | Updated gap and stack spacing custom properties to set vertical spacing to 0 (identical to site theme) |
| themes/beginner/dest/editor.css | Compiled CSS reflecting source changes plus autoprefixer updates |
| themes/beginner/dest/bundle.css | Compiled CSS with autoprefixer updates (removing obsolete vendor prefixes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.