This repository was archived by the owner on Apr 10, 2018. It is now read-only.
return {} instead of None when record not found#79
Open
freefrancisco wants to merge 1 commit intoappliedsec:masterfrom
Open
return {} instead of None when record not found#79freefrancisco wants to merge 1 commit intoappliedsec:masterfrom
freefrancisco wants to merge 1 commit intoappliedsec:masterfrom
Conversation
country_name_by_addr(addr) fails when the record is not found:
/usr/local/lib/python2.7/dist-packages/pygeoip/__init__.pyc in country_name_by_addr(self, addr)
489 return const.COUNTRY_NAMES[country_id]
490 elif self._databaseType in const.CITY_EDITIONS:
--> 491 return self.record_by_addr(addr).get('country_name')
492 else:
493 message = 'Invalid database type, expected Country or City'
AttributeError: 'NoneType' object has no attribute 'get'
In a previous version (0.2.6) that doesn't fail when a record is not found
record_by_addr(addr) returns {} instead of None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
country_name_by_addr(addr) fails when the record is not found:
/usr/local/lib/python2.7/dist-packages/pygeoip/init.pyc in country_name_by_addr(self, addr)
489 return const.COUNTRY_NAMES[country_id]
490 elif self._databaseType in const.CITY_EDITIONS:
--> 491 return self.record_by_addr(addr).get('country_name')
492 else:
493 message = 'Invalid database type, expected Country or City'
AttributeError: 'NoneType' object has no attribute 'get'
In a previous version (0.2.6) that doesn't fail when a record is not found
record_by_addr(addr) returns {} instead of None.