This repository was archived by the owner on Jan 27, 2020. It is now read-only.
Update zircote/swagger-php to 3 version#28
Closed
denkurbatov wants to merge 1 commit intoappointer:masterfrom
denkurbatov:update-swagger-php
Closed
Update zircote/swagger-php to 3 version#28denkurbatov wants to merge 1 commit intoappointer:masterfrom denkurbatov:update-swagger-php
denkurbatov wants to merge 1 commit intoappointer:masterfrom
denkurbatov:update-swagger-php
Conversation
Member
|
Hey, thanks for the PR! Did you test everything? Cause version 3.0 introduces a new spec and we should validate compatibility https://github.com/zircote/swagger-php/releases/tag/3.0.0. |
Author
Member
|
Sure! Thx!
Denys Kurbatov <notifications@github.com> schrieb am Sa., 28. Dez. 2019,
10:24:
… I'm delete my PR cause the same already exists - #17
<#17>
@fgreinus <https://github.com/fgreinus> If i will test everything (or
almost everything) is it any chance that PR will be merged to master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28?email_source=notifications&email_token=AAJN6MPNR25VVVT7C7C4LDLQ24LOXA5CNFSM4J7KXWN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYF73A#issuecomment-569401324>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJN6MP6MSN3JD4LHOMNV5LQ24LOXANCNFSM4J7KXWNQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update zircote/swagger-php to version 3.0 that supports php 7.4
Now when using php 7.4 got error:
Trying to access array offset on value of type bool at /var/www/app/vendor/zircote/swagger-php/src/StaticAnalyser.php:278)