Skip to content

Fix/numeric literal parser #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exomo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/numeric literal parser #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e83281
fix: Fix parser syntax for numeric literals
exomo Feb 14, 2026
e3c8f6c
fix: Parser syntax for some more numeric expression
exomo Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions lib/src/parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,13 @@ class ExpressionParser {
.flatten()
.map((v) => Identifier(v));

// Parse simple numeric literals: `12`, `3.4`, `.5`.
Parser<Literal> get numericLiteral => ((digit() | char('.')).and() &
(digit().star() &
((char('.') & digit().plus()) |
(char('x') & digit().plus()) |
(anyOf('Ee') &
anyOf('+-').optional() &
digit().plus()))
.optional()))
// Parse simple numeric literals: `12`, `3.4`, `.5`, `0xAB`.
Parser<Literal> get numericLiteral =>
((char('0') & anyOf('xX') & (digit() | anyOf('abcdefABCDEF')).plus()) |
(digit() | char('.')).and() &
((digit().star() & (char('.') & digit().plus()).optional()) &
(anyOf('Ee') & anyOf('+-').optional() & digit().plus())
.optional()))
.flatten()
.map((v) {
return Literal(num.parse(v), v);
Expand Down
24 changes: 17 additions & 7 deletions test/expressions_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,29 @@ void main() {
});

test('numeric literal', () {
for (var v in ['134', '.5', '43.2', '1e3', '1E-3', '1e+0', '0x01']) {
for (var v in [
'134',
'.5',
'43.2',
'1e3',
'1E-3',
'1e+0',
'.1e2',
'1.23e4',
'.6e-7',
'0x01',
'0xD3',
'0X1b'
]) {
var w = parser.numericLiteral.end().parse(v);
expect(w is Success, isTrue, reason: 'Failed parsing `$v`');
expect(w.value.value, num.parse(v));
expect(w.value.raw, v);
}

for (var v in [
'-134',
'.5.4',
'1e5E3',
]) {
expect(parser.numericLiteral.end().parse(v) is Success, isFalse);
for (var v in ['-134', '.5.4', '1e5E3', '5.', '12x34']) {
expect(parser.numericLiteral.end().parse(v) is Success, isFalse,
reason: 'Expected to fail parsing `$v`');
}
});

Expand Down