Upgrade ApptentiveModule.swift to work with v7 of the iOS SDK#275
Open
frankus wants to merge 3 commits intoPBI-9241-example-upgradefrom
Open
Upgrade ApptentiveModule.swift to work with v7 of the iOS SDK#275frankus wants to merge 3 commits intoPBI-9241-example-upgradefrom
frankus wants to merge 3 commits intoPBI-9241-example-upgradefrom
Conversation
frankus
changed the title
mikitahal
reviewed
Mar 14, 2026
| Apptentive.shared.canShowInteraction(event: Event(name: event), completion: { (result) -> Void in | ||
| switch result { | ||
| case .success(let canShowInteraction): | ||
| Task { |
There was a problem hiding this comment.
Should this also be annotated with @mainactor?
| let launchedMessageCenter = try await Apptentive.shared.presentMessageCenter(from: nil) | ||
| resolve(launchedMessageCenter) | ||
| case .failure(let error): | ||
| } catch let error { |
There was a problem hiding this comment.
Just a side note and not a blocker in any way, you can drop let error from catch, catch under the hood already has error so you can turn to it without explicitly declaring it
PoornimaApptentive
requested changes
Mar 16, 2026
| @@ -0,0 +1,37 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
Should this be added to git? Isn't it auto generated?
PoornimaApptentive
approved these changes
Mar 27, 2026
Contributor
PoornimaApptentive
left a comment
PoornimaApptentive
left a comment
There was a problem hiding this comment.
Left two comments. Non blocking. But dev need to review it before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update module to work with v7 iOS SDK.