Skip to content

remove template over IntegrationLayer#514

Merged
SeverinDiederichs merged 2 commits intoapt-sim:masterfrom
SeverinDiederichs:clean_IntegrationLayer_template
Mar 18, 2026
Merged

remove template over IntegrationLayer#514
SeverinDiederichs merged 2 commits intoapt-sim:masterfrom
SeverinDiederichs:clean_IntegrationLayer_template

Conversation

@SeverinDiederichs
Copy link
Collaborator

This PR is removing the template over the IntegrationLayer in AdePT.
The AdePTGeant4Integration was already explicitly used somewhere else, so it would have not worked. Also, by now it is clear that AdePT is tightly connected to G4 with the MC truth etc, so we can safely assume that a different integration layer won't be needed in the near future.

It was verified that this PR

  • Changes physics results
  • Does not change physics results

@SeverinDiederichs SeverinDiederichs added the cleaning improves code clarity, readability or other label Mar 17, 2026
@phsft-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment

Copy link
Contributor

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @SeverinDiederichs !

@SeverinDiederichs SeverinDiederichs force-pushed the clean_IntegrationLayer_template branch from b924e53 to 5801597 Compare March 17, 2026 18:09
@SeverinDiederichs SeverinDiederichs merged commit 1bb597b into apt-sim:master Mar 18, 2026
4 checks passed
@SeverinDiederichs SeverinDiederichs deleted the clean_IntegrationLayer_template branch March 18, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleaning improves code clarity, readability or other

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants