Refactor AdePT into 2 libraries 3: Remove AdePTGeant4Integration dependency from AdePTTransport initialization#519
Merged
SeverinDiederichs merged 5 commits intoapt-sim:masterfrom Mar 18, 2026
Conversation
|
Can one of the admins verify this patch? |
SeverinDiederichs
changed the title
SeverinDiederichs
force-pushed
the
remove_integration_dependency_in_AdePTTransport
branch
from
887e748 to
c3015ff
Compare
SeverinDiederichs
deleted the
remove_integration_dependency_in_AdePTTransport
branch
SeverinDiederichs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR belongs the the refactor of AdePT described in #516.
It is based on #518 and should not be reviewed before that one is merged.
This PR factors out all host-side initializations that were done in the AdePTTransport. Now, they are done in the AdePTTrackingManager (in a separate function). This way, the AdePTTransport does not depend on the AdePTGeant4Integration anymore in the initialization (it still does in the
Flushand subsequently in theProcessGPUSteps).This cleans up quite a few interfaces and only the G4HepEm config needs to be passed, not the full tracking manager anymore.
There is still a split of host data init - init on device - finalization of host data init - finalization of device data init, which is caused by the dependency of the g4hepem state for the finalization of the host data init.
This will be cleaned next.
It was verified that this PR