Refactor AdePT into 2 libraries 6: Refactor static geometry functions#522
Open
SeverinDiederichs wants to merge 6 commits intoapt-sim:masterfrom
Open
Refactor AdePT into 2 libraries 6: Refactor static geometry functions#522SeverinDiederichs wants to merge 6 commits intoapt-sim:masterfrom
SeverinDiederichs wants to merge 6 commits intoapt-sim:masterfrom
Conversation
|
Can one of the admins verify this patch? |
… it from worker, as data might be deleted before the AdePTTransport is
SeverinDiederichs
force-pushed
the
factor_out_geometry_bridge
branch
from
c9769d5 to
347252e
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR belongs to the refactor of AdePT described in #516.
This PR is based on #520 and should not be reviewed before that one is merged.
This PR extracts the static geometry setup and mapping logic out of
AdePTGeant4Integrationinto a dedicatedAdePTGeometryBridge.The goal is to separate the global geometry bridge responsibilities from the per-thread Geant4 integration object.
Before
AdePTGeant4Integrationdid both:This PR factors out the global geometry conversion and lookup into a separate helper. This makes the intended architecture clearer, without changing behavior.
It was verified that this PR