Handle filename contains multiple "."#23
Open
ntvthuyen wants to merge 3 commits intoaqeelanwar:masterfrom
Open
Handle filename contains multiple "."#23ntvthuyen wants to merge 3 commits intoaqeelanwar:masterfrom
ntvthuyen wants to merge 3 commits intoaqeelanwar:masterfrom
Conversation
split_path = f.rsplit(".") only can't handle filenames that contain more than "." Ex: file.30.26.jpg
It will produce an opencv write error. (It will try to cv.imwrite("file.30",img ).
In this modification, I join all elements of split_path array from the start to (n - 1) th to create new split_path with just 2 elements.
Ex: file.30.26.jpg -> ["file","30","26","jpg"] -> ["file.30.26","jpg"]
tintinmaster
suggested changes
Mar 1, 2022
tintinmaster
left a comment
tintinmaster
left a comment
There was a problem hiding this comment.
The same line split_path = [".".join(split_path[:-1]),split_path[-1]] is also needed in line 172
Co-authored-by: Tim Schneider <tim.schneider1337@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split_path = f.rsplit(".") only can't handle filenames that contain more than "." Ex: file.30.26.jpg
It will produce an opencv write error. (It will try to cv.imwrite("file.30",img ).
In this modification, I join all elements of split_path array from the start to (n - 1) th to create new split_path with just 2 elements.
Ex: file.30.26.jpg -> ["file","30","26","jpg"] -> ["file.30.26","jpg"]